Optimize Elaboration #736
Merged
Merged
Conversation
Closed
Member
|
Thanks @vrindisbacher -- seems to give some nice improvements in the LH benchmarks too! |
Collaborator
Author
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ranjitjhala, this one is from the liquid-fixpoint origin but has the same changes as #735
(copying over notes)
A few changes are implemented here:
applyExprinelabuntil after all the elaboration has taken place.Visitorand typeFolderinto two separate structures.Statemonad for folding and replace it with theReadermonad - similar to what is implemented forCheckMunifyExpr. This seemed to be re-traversing the expression tree and creating type substitutions by unifying sorts that were already unified inelabEAppSort.[RJ: All of these together yield massive speedups for some
fluxbenchmarks]