Split out Bag theory, elaborate Maps and Bags into Arrays#703
Merged
Conversation
nikivazou
approved these changes
Sep 10, 2024
| constraint: | ||
| env [ 1; 2; 3; 4; 5 ] | ||
| lhs {v : int | true } | ||
| rhs {v : int | m2 = Map_union m4 m4 } |
Member
There was a problem hiding this comment.
This is removed because Map_union is no more supported?
Contributor
Author
There was a problem hiding this comment.
Yes, this operation is only defined for Maps with integer values, so it got moved into the Bag theory as Bag_union
Contributor
Author
|
For the reference, the Map operations we're removing here were first introduced in #624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a continuation of #688, this PR elaborates Map operations into Array ones, allowing for the correct handling of polymorphic Map values.
It also separates Bags (i.e., integer-valued maps) from generic Maps and removes some ad-hoc Map operations that are currently only implementable as Z3 lambdas (
prj,shiftandto_set). This is a precursor to adding CVC5 support, as the latter does not support arbitrary Array operations, but instead has a generic SMTLIB Array theory (withconst,storeandselect) and separate theories of Sets and Bags.