CMake: error out on warnings for strict/missing prototypes.#1462
Merged
rouault merged 1 commit intouclouvain:masterfrom Mar 9, 2023
Merged
CMake: error out on warnings for strict/missing prototypes.#1462rouault merged 1 commit intouclouvain:masterfrom
rouault merged 1 commit intouclouvain:masterfrom
Conversation
Collaborator
|
@sebras errors for the mingw_64 target are at https://my.cdash.org/viewBuildError.php?buildid=2301396 |
aaef606 to
4ee8bdc
Compare
Contributor
Author
I know, I found them. I've fixed one of them, but the error relating to DllMain is puzzling to me (I'm mainly a Linux developer). :) |
And fix strict-prototypes/missing-prototypes warnings.
Collaborator
|
perhaps try the following change: |
Contributor
Author
|
I'll just follow the lead of cairo and declare DllMain locally in the file. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix strict-prototypes/missing-prototypes warnings.