MockGen header comment: trim .exe suffix on Windows#119
Merged
r-hang merged 2 commits intouber-go:mainfrom Nov 17, 2023
Merged
Conversation
|
|
marten-seemann
approved these changes
Nov 10, 2023
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
approved these changes
Nov 11, 2023
Contributor
Author
|
@r-hang Are you able to start the workflow on this PR? Thank you! |
Contributor
Author
|
@tchung1118 Are you able to start the workflow on this PR? Thank you! |
r-hang
approved these changes
Nov 17, 2023
Contributor
r-hang
left a comment
There was a problem hiding this comment.
Sorry for the delay, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #118