Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
============================================
+ Coverage 88.01% 88.09% +0.07%
+ Complexity 2228 2204 -24
============================================
Files 85 84 -1
Lines 7212 7175 -37
Branches 1428 1423 -5
============================================
- Hits 6348 6321 -27
+ Misses 436 431 -5
+ Partials 428 423 -5 ☔ View full report in Codecov by Sentry. |
InferredJARModelsHandler
yuxincs
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, all logic for parsing loading
astubxfiles is consolidated into theLibraryModelsHandler.ExternalStubxLibraryModelsclass and is uniform forastubxfiles generated via JarInfer or from source code, which will ease future bug fixes and changes.We copied over the logic from
InferredJARModelsHandlerfor loading Android SDK models if present. We also update the logic forExternalStubxLibraryModels.nonNullParameters()andExternalStubxLibraryModels.nullableReturns()to pull in all the relevant info from the parsedastubxfile.Fixes #1072