Fix JarInfer parameter indexes for instance methods#1071
Merged
msridhar merged 6 commits intouber:masterfrom Nov 12, 2024
Merged
Fix JarInfer parameter indexes for instance methods#1071msridhar merged 6 commits intouber:masterfrom
msridhar merged 6 commits intouber:masterfrom
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
=========================================
Coverage 87.86% 87.87%
+ Complexity 2211 2210 -1
=========================================
Files 85 85
Lines 7188 7190 +2
Branches 1425 1423 -2
=========================================
+ Hits 6316 6318 +2
Misses 438 438
Partials 434 434 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Nov 12, 2024
Collaborator
yuxincs
left a comment
There was a problem hiding this comment.
Awesome, and thanks for splitting up the PRs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when JarInfer wrote an
astubxfile, it treated the receiver parameter of an instance method as being at parameter index 0. In other places we do library modeling, the receiver parameter is ignored and the next parameter is treated as being at index 0. The latter handling is more sensible for NullAway, as we have not needed to do any kind of library modeling of receiver parameters yet.This PR switches the JarInfer logic to ignore the receiver parameter like in other places. This breaks pre-existing
astubxfiles, so we disable an integration test for now. We will bump the astubx version and fix up existing files in a later PR as part of an overall fix to #1072 (fixing in multiple PRs to ease reviewing).