Create basic unit tests for library model generation#1031
Merged
msridhar merged 6 commits intouber:masterfrom Sep 6, 2024
Merged
Create basic unit tests for library model generation#1031msridhar merged 6 commits intouber:masterfrom
msridhar merged 6 commits intouber:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
============================================
+ Coverage 86.06% 87.28% +1.21%
- Complexity 2110 2117 +7
============================================
Files 83 83
Lines 6932 6943 +11
Branches 1344 1346 +2
============================================
+ Hits 5966 6060 +94
+ Misses 550 456 -94
- Partials 416 427 +11 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for #1006. When working on that PR I realized we really need some unit tests to more easily debug various scenarios (right now all we have are integration tests). Plus this will make our code coverage reports more useful. This adds some infrastructure for unit tests and a couple of basic tests; we will add more as we go. Also fix a couple minor issues in
LibraryModelGenerator.