[WIP] Fix not-building-on-master-or-other-important-branches issue#407
Closed
chuck-sys wants to merge 1 commit into
Closed
[WIP] Fix not-building-on-master-or-other-important-branches issue#407chuck-sys wants to merge 1 commit into
chuck-sys wants to merge 1 commit into
Conversation
632ab4b to
6b5bc2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 67 67
Lines 4459 4459
Branches 251 251
=======================================
Hits 4238 4238
Misses 178 178
Partials 43 43Continue to review full report at Codecov.
|
Collaborator
Author
|
I think I'm not gonna complicate things and roll-back the changes I'd in mind. |
Now, we have 2 separate workflows. One builds on PR and one builds on push to the protected branches. Rename workflows to be more straightforward Fix filenames for the actions and replace them Turn everything back to a string Add additional workflow for documentation checking Fix #406 Make docs run all the time Forgot that we aren't using pipenv for this one Split workflow push/pull_request properly There is no difference in function between the two now.
b20e548 to
71736ed
Compare
Collaborator
Author
|
Closing because it thinks there is a documentation lint when i clearly deleted it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Give a brief description of your changes: Now, we have 2 separate workflows. One builds on PR and one builds on push to the protected branches.