Multiple remotes, TOML configuration#99
Merged
Merged
Conversation
* Initial support for multiple remotes * Switch to TOML configuration file * Configuration struct redesign * Rename client.init to client.config
PiggySpeed
requested changes
Mar 3, 2018
PiggySpeed
left a comment
Contributor
There was a problem hiding this comment.
Took some time to figure out what was happening, but it looks good.
| config.Remotes = append(config.Remotes, remote) | ||
| } | ||
|
|
||
| // RemoveRemote removes remote at with given name |
Contributor
There was a problem hiding this comment.
*removes remote with given name
| if err != nil { | ||
| log.Fatal("invalid response - aborting") | ||
| } | ||
| if response != "y" { |
Contributor
There was a problem hiding this comment.
Is it standard behaviour for cli tools to treat all inputs except "y" as a "n"?
Member
Author
There was a problem hiding this comment.
I am not too sure actually. Personally I think since this is a destructive action, any command other than y can safely be assumed to be a "no"
Contributor
There was a problem hiding this comment.
Ok, that's fine with me then!
PiggySpeed
approved these changes
Mar 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s):
inertia reset#69👷 Changes
client.Configstruct.inertia.tomlmainpackage seems to have dropped our coverage significantly 😢🔦 Testing Instructions
inertia init inertia remote add local inertia remote add gcloud inertia remote ls -v inertia remote rm gcloud inertia remote lsWorks for the deploy commands too:
inertia local up inertia gcloud up😁
Some other things: