Skip to content

client: enforce a minimum daemon version#708

Merged
bobheadxi merged 2 commits into
masterfrom
client/enforce-versions
Oct 19, 2020
Merged

client: enforce a minimum daemon version#708
bobheadxi merged 2 commits into
masterfrom
client/enforce-versions

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

Since the switch to the new container registry (#692), the bootstrap script will no longer correctly work with pre-0.6.2 images. This change adds a check that requires newer images in remote configuration.

For context, we published an v0.6.2 image: https://github.com/orgs/ubclaunchpad/packages/container/inertiad/93246

@bobheadxi bobheadxi requested a review from a team October 19, 2020 11:15
@bobheadxi bobheadxi mentioned this pull request Oct 19, 2020
5 tasks
@codecov

codecov Bot commented Oct 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #708 into master will increase coverage by 8.52%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   40.91%   49.43%   +8.52%     
==========================================
  Files          17       75      +58     
  Lines        1039     3561    +2522     
==========================================
+ Hits          425     1760    +1335     
- Misses        543     1546    +1003     
- Partials       71      255     +184     
Flag Coverage Δ
#test-bootstrap-amazon-1 1.24% <0.00%> (?)
#test-bootstrap-centos-7 1.24% <0.00%> (?)
#test-bootstrap-debian-9.3 1.24% <0.00%> (?)
#test-bootstrap-pull-image 1.24% <0.00%> (?)
#test-bootstrap-ubuntu-16.04 1.24% <0.00%> (?)
#test-bootstrap-ubuntu-18.04 1.24% <0.00%> (?)
#test-core 49.03% <70.00%> (?)
#test-windows 41.31% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/provision/provision.go 0.00% <0.00%> (ø)
client/client.go 73.37% <100.00%> (+0.79%) ⬆️
daemon/inertiad/containers/docker.go 60.00% <0.00%> (ø)
daemon/inertiad/webhook/docker.go 100.00% <0.00%> (ø)
daemon/inertiad/daemon/status.go 74.47% <0.00%> (ø)
daemon/inertiad/crypto/password.go 88.89% <0.00%> (ø)
daemon/inertiad/daemon/logs.go 0.00% <0.00%> (ø)
daemon/inertiad/daemon/prune.go 0.00% <0.00%> (ø)
local/git/git.go 41.18% <0.00%> (ø)
cmd/core/utils/input/input.go 77.50% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41efb28...6742ad9. Read the comment docs.

@bobheadxi bobheadxi merged commit d3f0488 into master Oct 19, 2020
@bobheadxi bobheadxi deleted the client/enforce-versions branch October 19, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant