Skip to content

cmd: improve reauthentication flow#702

Merged
bobheadxi merged 5 commits into
masterfrom
cmd/reauthenticate
Oct 18, 2020
Merged

cmd: improve reauthentication flow#702
bobheadxi merged 5 commits into
masterfrom
cmd/reauthenticate

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): Closes #699


👷 Changes

Save last-logged-in user and improve advice for logging in

🔦 Testing Instructions

Explain how to test your changes, if applicable.

@bobheadxi bobheadxi requested a review from a team October 18, 2020 06:44
@codecov

codecov Bot commented Oct 18, 2020

Copy link
Copy Markdown

Codecov Report

Merging #702 into master will increase coverage by 8.73%.
The diff coverage is 70.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   40.60%   49.33%   +8.73%     
==========================================
  Files          17       75      +58     
  Lines        1037     3550    +2513     
==========================================
+ Hits          421     1751    +1330     
- Misses        544     1544    +1000     
- Partials       72      255     +183     
Flag Coverage Δ
#test-bootstrap-amazon-1 1.24% <0.00%> (?)
#test-bootstrap-centos-7 1.24% <0.00%> (?)
#test-bootstrap-debian-9.3 1.24% <0.00%> (?)
#test-bootstrap-pull-image 1.24% <0.00%> (?)
#test-bootstrap-ubuntu-16.04 1.24% <0.00%> (?)
#test-bootstrap-ubuntu-18.04 1.24% <0.00%> (?)
#test-core 48.93% <70.59%> (?)
#test-windows 40.91% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfg/remote.go 78.95% <ø> (ø)
daemon/inertiad/auth/permissions.go 58.48% <25.00%> (ø)
daemon/inertiad/crypto/token.go 78.27% <33.34%> (ø)
api/response.go 88.89% <100.00%> (ø)
client/client.go 72.58% <100.00%> (+1.09%) ⬆️
daemon/inertiad/crypto/authtest.go 100.00% <0.00%> (ø)
daemon/inertiad/build/util.go 60.00% <0.00%> (ø)
daemon/inertiad/daemon/setup.go 0.00% <0.00%> (ø)
daemon/inertiad/util/util.go 100.00% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f3c70...ff8f937. Read the comment docs.

@bobheadxi bobheadxi merged commit af603c9 into master Oct 18, 2020
@bobheadxi bobheadxi deleted the cmd/reauthenticate branch October 18, 2020 08:22
@bobheadxi bobheadxi mentioned this pull request Oct 18, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unclear what to do if login token is expired

1 participant