Skip to content

chore: publish to github container registry as well#685

Merged
bobheadxi merged 1 commit into
masterfrom
chore/publish-to-gcr
Sep 24, 2020
Merged

chore: publish to github container registry as well#685
bobheadxi merged 1 commit into
masterfrom
chore/publish-to-gcr

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): n/a


👷 Changes

Adds a publish step for GitHub Container Registry as a fallback (since Docker Hub limits are getting reduced)

not sure if we should migrate wholesale yet, but oh well

🔦 Testing Instructions

n/a

@bobheadxi bobheadxi requested a review from a team September 24, 2020 12:44
@bobheadxi bobheadxi force-pushed the chore/publish-to-gcr branch 2 times, most recently from 23945fb to 04bcd97 Compare September 24, 2020 12:50
@codecov

codecov Bot commented Sep 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #685 into master will increase coverage by 47.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #685       +/-   ##
===========================================
+ Coverage    1.16%   49.11%   +47.95%     
===========================================
  Files          75       75               
  Lines        3888     3521      -367     
===========================================
+ Hits           45     1729     +1684     
+ Misses       3835     1541     -2294     
- Partials        8      251      +243     
Impacted Files Coverage Δ
client/bootstrap/bootstrap.go 72.14% <0.00%> (-0.44%) ⬇️
cmd/root.go 0.00% <0.00%> (ø)
local/init.go 0.00% <0.00%> (ø)
cmd/contrib.go 0.00% <0.00%> (ø)
cmd/provision/provision.go 0.00% <0.00%> (ø)
cmd/core/utils/out/print.go 0.00% <0.00%> (ø)
daemon/inertiad/daemon/up.go 0.00% <0.00%> (ø)
daemon/inertiad/daemon/env.go 0.00% <0.00%> (ø)
daemon/inertiad/daemon/logs.go 0.00% <0.00%> (ø)
daemon/inertiad/daemon/prune.go 0.00% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab3128...ca8db28. Read the comment docs.

@bobheadxi bobheadxi force-pushed the chore/publish-to-gcr branch 5 times, most recently from 0e13cf7 to 3b733ed Compare September 24, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant