Skip to content

cmd: min version checks#670

Merged
bobheadxi merged 3 commits into
masterfrom
cmd/min-version
Apr 3, 2020
Merged

cmd: min version checks#670
bobheadxi merged 3 commits into
masterfrom
cmd/min-version

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): Closes #664


👷 Changes

Adds a new field, version, for tracking a min version, e.g. version = v0.6.1
=> >= v0.6.1 < v0.7.0

Add cli-side version validation

@bobheadxi bobheadxi requested a review from a team April 3, 2020 05:28
@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Apr 3, 2020
@codecov

codecov Bot commented Apr 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #670 into master will increase coverage by 0.12%.
The diff coverage is 69.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   51.59%   51.71%   +0.12%     
==========================================
  Files          75       75              
  Lines        3856     3882      +26     
==========================================
+ Hits         1989     2007      +18     
- Misses       1618     1624       +6     
- Partials      249      251       +2     
Impacted Files Coverage Δ
cfg/project.go 73.44% <69.24%> (-2.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc6f9f...140218f. Read the comment docs.

@bobheadxi bobheadxi merged commit 71a7805 into master Apr 3, 2020
@bobheadxi bobheadxi deleted the cmd/min-version branch April 3, 2020 05:56
@bobheadxi bobheadxi mentioned this pull request Apr 3, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cfg: add inertia min version

1 participant