Skip to content

cmd(core): prompt improvements#663

Merged
bobheadxi merged 3 commits into
masterfrom
cmd/prompts
Apr 1, 2020
Merged

cmd(core): prompt improvements#663
bobheadxi merged 3 commits into
masterfrom
cmd/prompts

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): Closes #569


👷 Changes

  • improved cmd/core/input with new prompt builder, available via NewPrompt()
  • move walkthrough helpers to respective packages
  • added some missing (y/N) prompts

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Apr 1, 2020
@bobheadxi bobheadxi requested a review from a team April 1, 2020 18:55
@codecov

codecov Bot commented Apr 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #663 into master will decrease coverage by 4.29%.
The diff coverage is 72.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   55.55%   51.26%   -4.28%     
==========================================
  Files          69       74       +5     
  Lines        3478     3812     +334     
==========================================
+ Hits         1932     1954      +22     
- Misses       1300     1612     +312     
  Partials      246      246              
Impacted Files Coverage Δ
cmd/provision/provision.go 0.00% <0.00%> (ø)
cmd/init.go 11.41% <44.83%> (ø)
cmd/core/utils/input/input.go 80.00% <92.11%> (+3.19%) ⬆️
cmd/provision/input.go 100.00% <100.00%> (ø)
cmd/contrib.go 0.00% <0.00%> (ø)
cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63056c3...51f26a8. Read the comment docs.

@bobheadxi bobheadxi merged commit 60b3b25 into master Apr 1, 2020
@bobheadxi bobheadxi deleted the cmd/prompts branch April 1, 2020 19:32
@bobheadxi bobheadxi mentioned this pull request Apr 3, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd: improve io utilities

1 participant