daemon(deployment): integrate slack config#661
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
==========================================
- Coverage 55.70% 55.55% -0.14%
==========================================
Files 67 69 +2
Lines 3431 3478 +47
==========================================
+ Hits 1911 1932 +21
- Misses 1274 1300 +26
Partials 246 246
Continue to review full report at Codecov.
|
|
Looks good to me. Keep up the great work! 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #621
👷 Changes
🔦 Testing Instructions
There are unit tests, set up slack workspace to try it out - see #585