Skip to content

daemon: log history update as non-critical failure#641

Merged
bobheadxi merged 1 commit into
masterfrom
daemon/history-update
Mar 5, 2020
Merged

daemon: log history update as non-critical failure#641
bobheadxi merged 1 commit into
masterfrom
daemon/history-update

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): Closes #626


👷 Changes

Make container update failure a non-critical error to avoid failing a build

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 5, 2020
@bobheadxi bobheadxi requested a review from a team March 5, 2020 07:38
@codecov

codecov Bot commented Mar 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #641 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   55.53%   55.54%   +0.02%     
==========================================
  Files          68       68              
  Lines        3395     3394       -1     
==========================================
  Hits         1885     1885              
+ Misses       1266     1265       -1     
  Partials      244      244
Impacted Files Coverage Δ
daemon/inertiad/daemon/up.go 0% <0%> (ø) ⬆️
daemon/inertiad/log/streamer.go 79.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ac3a1...b3ab8f9. Read the comment docs.

@bobheadxi bobheadxi merged commit 0d13d89 into master Mar 5, 2020
@bobheadxi bobheadxi deleted the daemon/history-update branch March 5, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy: history update can fail if container starts slowly, makes superfluous header write

1 participant