Skip to content

provision(ec2): filter out ECS images from recommendations#640

Merged
bobheadxi merged 1 commit into
masterfrom
provision/no-ecs
Mar 5, 2020
Merged

provision(ec2): filter out ECS images from recommendations#640
bobheadxi merged 1 commit into
masterfrom
provision/no-ecs

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

🎟️ Ticket(s): Closes #633


👷 Changes

Filters out ECS images from EC2 provisioning recommendations

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 5, 2020
@bobheadxi bobheadxi requested a review from a team March 5, 2020 06:21
@bobheadxi bobheadxi changed the title provision: filter out ECS images from recommendations provision(ec2): filter out ECS images from recommendations Mar 5, 2020
@codecov

codecov Bot commented Mar 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #640 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
- Coverage   55.70%   55.53%   -0.17%     
==========================================
  Files          68       68              
  Lines        3381     3395      +14     
==========================================
+ Hits         1883     1885       +2     
- Misses       1254     1266      +12     
  Partials      244      244              
Impacted Files Coverage Δ
daemon/inertiad/project/deployment.go 32.76% <0.00%> (-1.03%) ⬇️
cfg/project.go 76.32% <0.00%> (ø)
daemon/inertiad/daemon/up.go 0.00% <0.00%> (ø)
client/client.go 73.31% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65708d...ba606a0. Read the comment docs.

@bobheadxi bobheadxi merged commit 61ac3a1 into master Mar 5, 2020
@bobheadxi bobheadxi deleted the provision/no-ecs branch March 5, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provision, daemon: ECS AMI's have a new ecs-agent, makes inertia confused

1 participant