cmd: handle boolean types in config options#614
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 55.82% 55.88% +0.07%
==========================================
Files 68 68
Lines 3372 3377 +5
==========================================
+ Hits 1882 1887 +5
Misses 1248 1248
Partials 242 242
Continue to review full report at Codecov.
|
bobheadxi
approved these changes
Aug 28, 2019
bobheadxi
left a comment
Member
There was a problem hiding this comment.
awesome, thank you for fixing this! 😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #590
👷 Changes
Just identify the type of
fieldValand in the correct evaluation usestrconvto validate the input.The valid values could be (doc):
🔦 Testing Instructions
go test ./cfgormake test