Skip to content

config: hack in an ignore-death option#608

Merged
bobheadxi merged 3 commits into
v0.5.xfrom
config/#607-hotfix-ignore-death
Mar 17, 2019
Merged

config: hack in an ignore-death option#608
bobheadxi merged 3 commits into
v0.5.xfrom
config/#607-hotfix-ignore-death

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Mar 17, 2019

Copy link
Copy Markdown
Member

🎟️ Ticket(s): for #607


👷 Changes

  • in your config, manually add a field under remote configuration:
dont-kill-on-death = true

then up

more context in ticket. something like this will need to be separately implemented for what's on master

🔦 Testing Instructions

as above

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 17, 2019
@rwblickhan

Copy link
Copy Markdown
Contributor

Maybe it should be no-kill-on-death, that seems prettier 😛

@codecov

codecov Bot commented Mar 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #608 into v0.5.x will decrease coverage by 0.07%.
The diff coverage is 23.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.5.x     #608      +/-   ##
==========================================
- Coverage   56.21%   56.14%   -0.06%     
==========================================
  Files          60       60              
  Lines        2991     3000       +9     
==========================================
+ Hits         1681     1684       +3     
- Misses       1102     1107       +5     
- Partials      208      209       +1
Impacted Files Coverage Δ
cfg/remote.go 100% <ø> (ø) ⬆️
daemon/inertiad/daemon/up.go 0% <0%> (ø) ⬆️
daemon/inertiad/project/deployment.go 39.9% <11.12%> (-0.33%) ⬇️
client/client.go 70.38% <60%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d755488...59bbd5d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants