Skip to content

cmd: switch back to kyokomi/emoji#599

Merged
bobheadxi merged 1 commit into
masterfrom
cmd/emoji-fork
Mar 6, 2019
Merged

cmd: switch back to kyokomi/emoji#599
bobheadxi merged 1 commit into
masterfrom
cmd/emoji-fork

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Mar 6, 2019

Copy link
Copy Markdown
Member

🎟️ Ticket(s): related to #595


👷 Changes

My PR was merged upstream (kyokomi/emoji#32), so we can switch back to original library now

Also I deleted my fork so Travis is failing lol https://travis-ci.org/ubclaunchpad/inertia/builds/501923028

🔦 Testing Instructions

run tests

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 6, 2019
@bobheadxi bobheadxi requested a review from a team March 6, 2019 04:51
@ghost ghost requested review from kimoantiqe, mRabitsky and nicholaschinjie March 6, 2019 04:51
@bobheadxi bobheadxi requested review from seifghazi and yaoharry March 6, 2019 04:51
@codecov

codecov Bot commented Mar 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #599   +/-   ##
======================================
  Coverage    56.4%   56.4%           
======================================
  Files          69      69           
  Lines        3300    3300           
======================================
  Hits         1861    1861           
  Misses       1203    1203           
  Partials      236     236
Impacted Files Coverage Δ
cmd/core/utils/out/decor.go 95.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275f47b...40087a0. Read the comment docs.

@bobheadxi bobheadxi merged commit 4d124ef into master Mar 6, 2019
@bobheadxi bobheadxi deleted the cmd/emoji-fork branch March 6, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: finalized needs review and final approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants