cmd: prevent command names from being used as remotes#592
Merged
Conversation
yaoharry
approved these changes
Feb 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 55.38% 55.36% -0.01%
==========================================
Files 67 67
Lines 3005 3006 +1
==========================================
Hits 1664 1664
- Misses 1145 1146 +1
Partials 196 196
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #591
👷 Changes
Adding a remote first checks if the remote is also a command name
🔦 Testing Instructions