deploy: container history#578
Merged
Merged
Conversation
bobheadxi
reviewed
Feb 22, 2019
bobheadxi
reviewed
Feb 22, 2019
bobheadxi
reviewed
Feb 22, 2019
bobheadxi
reviewed
Feb 24, 2019
bobheadxi
requested changes
Feb 27, 2019
seifghazi
commented
Mar 6, 2019
bobheadxi
reviewed
Mar 6, 2019
seifghazi
commented
Mar 6, 2019
yaoharry
approved these changes
Mar 16, 2019
yaoharry
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Make sure to test it.
seifghazi
commented
Mar 29, 2019
bobheadxi
reviewed
Mar 29, 2019
bobheadxi
reviewed
Mar 30, 2019
| args args | ||
| wantErr bool | ||
| }{ | ||
| {"valid project build", args{"projectB", DeploymentMetadata{"hash", "ID", "status", "time"}, 2}, false}, |
Member
There was a problem hiding this comment.
might want to add some potential error cases here - what if the project name is empty? etc.
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=========================================
- Coverage 56.33% 55.82% -0.5%
=========================================
Files 68 68
Lines 3299 3372 +73
=========================================
+ Hits 1858 1882 +24
- Misses 1205 1248 +43
- Partials 236 242 +6
Continue to review full report at Codecov.
|
bobheadxi
reviewed
Mar 30, 2019
bobheadxi
requested changes
Mar 31, 2019
Member
There was a problem hiding this comment.
@seifghazi so close! looks like there's just one last thing - a lint error:
https://travis-ci.org/ubclaunchpad/inertia/jobs/513613829#L527
+/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/inertiad/project/data.go:150:1: comment on exported method DeploymentDataManager.AddProjectBuildData should be of the form "AddProjectBuildData ..."
bobheadxi
approved these changes
Mar 31, 2019
bobheadxi
left a comment
Member
There was a problem hiding this comment.
it's all green! awesome work, and congrats on your first PR 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): for #293
👷 Changes
Added containerBucket to manage container history for a deployed projects.
Once a project is successfully deployed, the bucket is updated with the container ID and the git project's most recent commit hash. The commit hash can be later be used to identify successful
builds and rollback to prior version when needed.
Before moving forward we might need to refactor data.go and extract env and container functionality to separate modules.
🔦 Testing Instructions
Explain how to test your changes, if applicable.