Testing/#545 convert assert nil#575
Merged
Merged
Conversation
Co-Authored-By: yaoharry <harryyao13@gmail.com>
…d/inertia into testing/client-tests
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 62 62
Lines 3019 3019
=======================================
Hits 1706 1706
Misses 1104 1104
Partials 209 209Continue to review full report at Codecov.
|
Member
|
@yaoharry there are conflicts here in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #545
👷 Changes
Converted asset.Nil to assert.NoError
Made sure that the test involved an error test and not a nil test.
🔦 Testing Instructions
Run
make test