daemon: return ok if webhook type is ping#532
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 56.25% 56.21% -0.04%
==========================================
Files 60 60
Lines 2985 2991 +6
==========================================
+ Hits 1679 1681 +2
- Misses 1098 1102 +4
Partials 208 208
Continue to review full report at Codecov.
|
533fe62 to
75af90d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #525
👷 Changes
EventTypeis now a custom string type for claritypingevent (see ticket Webhook deliveries time out #525 for more context)PingEventand returns appropriately🔦 Testing Instructions
Follow the CONTRIBUTING instructions and set up webhooks - GitHub should send a test event that is verified by inertiad.
Also run the tests