Description

Same as ubccr/xdmod#1789 and ubccr/xdmod#1794 but for the xdmod-supremm module.

This PR also removes the _tests suffix from the test directory names to be consistent with the main xdmod module.

Tests performed

The changes to classes/Rest/Controllers/EfficiencyControllerProvider.php are covered partially by the existing test tests/integration_tests/lib/REST/EfficiencyControllerProviderTest.php::testCPUUsageScatterPlotEndpointMalformedRequest, and additional coverage will be provided in #350.

To make sure the changes in this PR don't affect any other tests that are run, I did the following in a Docker container running tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1:

1. Run the following commands:

   export COMPOSER_ALLOW_SUPERUSER=1
   export XDMOD_REALMS='jobs,storage,cloud,supremm,jobefficiency'
   export XDMOD_IS_CORE=yes
   export XDMOD_INSTALL_DIR=/xdmod
   export XDMOD_TEST_MODE=upgrade
   export XDMOD_SRC_DIR=./../xdmod
   git clone https://github.com/ubccr/xdmod-supremm /xdmod-supremm
   dnf module -y reset nodejs
   dnf module -y install nodejs:16
   git clone https://github.com/ubccr/xdmod $XDMOD_SRC_DIR
   cd /xdmod
   git checkout 411f7169b4f96a79b0aa237a560564fec2a91d9a
   cd /xdmod-supremm
   ln -s `pwd` $XDMOD_SRC_DIR/open_xdmod/modules/supremm
   ./tests/ci/scripts/install_mongo.sh
   composer install --no-progress
   composer config -g cache-files-ttl 315360000
   composer install -d $XDMOD_SRC_DIR --no-progress
   mkdir -p ~/phpunit
   mkdir -p /tmp/screenshots
   export XDMOD_SOURCE_DIR=/xdmod
   export SHIPPABLE_BUILD_DIR=/xdmod-supremm
   pushd $XDMOD_SRC_DIR
   ~/bin/buildrpm xdmod supremm
   popd
   ./tests/integration_tests/scripts/bootstrap.sh
   ./tests/integration_tests/scripts/validate.sh
   composer install -d $XDMOD_SRC_DIR --no-progress
   composer install --no-progress
   ./tests/ci/scripts/qa-test-setup.sh
   export XDMOD_INSTALL_DIR=/usr/share/xdmod
   ./tests/ci/scripts/post-install-test.sh
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/component_tests/runtests.sh
   ./tests/component_tests/runtests.sh > /component-before.txt
   composer install -d $XDMOD_SRC_DIR --no-progress
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/integration_tests/runtests.sh
   sed -i '/printerClass/d' ./tests/integration_tests/phpunit.xml.dist
   ./tests/integration_tests/runtests.sh > /integration-before.txt
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/regression_tests/runtests.sh
   ./tests/regression_tests/runtests.sh > /regression-before.txt
   ./tests/artifacts/update-artifacts.sh
   cd tests/unit_tests/
   sed -i '/printerClass/d' phpunit.xml.dist
   ../../vendor/bin/phpunit --debug . > /unit-before.txt
   cd /xdmod
   git checkout xdmod11.0
   cd /xdmod-supremm
   git clone https://github.com/aaronweeden/xdmod-supremm -b refactor-test-namespaces /xdmod-supremm-new
   unalias rm
   rm -r /xdmod-supremm/tests
   cp -r /xdmod-supremm{-new,}/tests
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/component/runtests.sh
   ./tests/component/runtests.sh > /component-after.txt
   composer install -d $XDMOD_SRC_DIR --no-progress
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/integration/runtests.sh
   ./tests/integration/runtests.sh > /integration-after.txt
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/regression/runtests.sh
   ./tests/regression/runtests.sh > /regression-after.txt
   ./tests/artifacts/update-artifacts.sh
   cd tests/unit/
   ../../vendor/bin/phpunit --debug . > /unit-after.txt
   cd /xdmod-supremm
   

2. Compare /unit-{before,after}.txt and make sure the only differences are namespace names and amount of time the tests ran.
3. Compare /component-{before,after}.txt and make sure the only differences are the test directory name and amount of time the tests ran.
4. Compare /regression-{before,after}.txt and make sure the only differences are namespace names, randomized parameters, amount of time the tests ran, and possibly transient "other notices" related to small differences in column values.
5. Compare /integration-{before,after}.txt and make sure the only differences are namespace names and amount of time the tests ran.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project as found in the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.