Merged
Conversation
6f7a568 to
a810979
Compare
Merged
jpwhite4
previously approved these changes
Nov 22, 2024
Member
jpwhite4
left a comment
There was a problem hiding this comment.
Recommend ignore the sonar cloud warnings and merge.
37dde22 to
d1121e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes warnings emitted by PHPUnit during the CI tests:
These warnings were not caught by CircleCI, since PHPUnit does not return a non-zero code when there are test runner warnings (as opposed to warnings about the tests themselves), and there does not appear to be a configuration setting to make it do so for these type of warnings. See sebastianbergmann/phpunit#2246 (comment).
Checklist: