Added Usage tab link loading for statistics link#1888
Conversation
aestoltm
left a comment
There was a problem hiding this comment.
Left a suggestions for a minor refactor when we know what dimension the url is referring to. There are also a few changes to some of the variable names so they are more consistent with the XDMoD language. I also included a small change so that this can work with the 'Summary Overview' charts. Even though we most likely will not support those charts with the chat bot I think it would be nice to support in the portal.
Please let me know if you have any questions on the suggested changes.
Co-authored-by: Andrew Stoltman <60742416+aestoltm@users.noreply.github.com>
|
The regex is throwing a sonar warning. Need to confirm if it needs to be adjusted. |
We shouldn't be using a regex in this code. We already have a library function that will parse the location string and get what we need out of it - since thats what the code already does! |
|
Tests will fail until I update some of the expected files for integration tests |
This reverts commit 2153585.
… page. Finding this bug also made me want to change the Ext Tree node ids to include 'node' to match node ids more easily
Added capability so that when you load a chart link from the usage tab ie https://xdmod.access-ci.org/index.php#tg_usage?node=statistic_Jobs_nodecount_utilization the usage tab will load that chart, instead of loading the default chart configuration
Note - this does not handle the case for group charts ie https://xdmod.access-ci.org/index.php#tg_usage?node=group_by_Jobs_nodecount which are handled like the old case and just load the default chart instead.
Motivation and Context
This allows users to share usage tab charts, as well as adds the production effort in creating an XDMod Chatbot