Merged
Conversation
There are two main changes here. 1. Rename `optimise` -> `optimize` (so we don't mix US and UK spellings). 2. Change the `optimize` boolean flag to a `uint32`, which can be used to indicate which optimization strategy to use.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 92.90% 92.85% -0.06%
==========================================
Files 18 18
Lines 1128 1148 +20
Branches 126 133 +7
==========================================
+ Hits 1048 1066 +18
- Misses 61 62 +1
- Partials 19 20 +1 ☔ View full report in Codecov by Sentry. |
neculalaura
previously approved these changes
May 14, 2024
Collaborator
neculalaura
left a comment
There was a problem hiding this comment.
can you explain a bit this optimising strategy? can talk about it tomorrow 🙂
| // of computed relations resulting in expensive write operations. | ||
| // 4 (graph) - Don't optimize. Lookups will need to use a graph traversal algorithm to derive | ||
| // relations. | ||
| // 8 (set) - Optimize by computing derived relations between principals, which the lookups |
Owner
Author
There was a problem hiding this comment.
Mainly to leave some numbers in-between so there's space to add other strategies or variations of strategies if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow different optimisation strategies to be used when creating relations.