Merged
Conversation
This change should help to indentify newly created tuples that aren't stored in the db.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 92.79% 92.90% +0.11%
==========================================
Files 18 18
Lines 1069 1128 +59
Branches 115 126 +11
==========================================
+ Hits 992 1048 +56
Misses 61 61
- Partials 16 19 +3 ☔ View full report in Codecov by Sentry. |
neculalaura
previously approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change utilises the
optimiseflag to compute and store derived relations when creating a new relation. Thecost_limitcan be used to avoid expensive DB operations during an insert.💡 If the cost of storing derived tuples is larger than the
cost_limit, the response will have a negativecostindicating the process has been aborted.