Skip to content

Change Resources service to use tuples instead of records#88

Merged
uatuko merged 1 commit intomainfrom
feature/resources-tuples
Apr 23, 2024
Merged

Change Resources service to use tuples instead of records#88
uatuko merged 1 commit intomainfrom
feature/resources-tuples

Conversation

@uatuko
Copy link
Copy Markdown
Owner

@uatuko uatuko commented Apr 23, 2024

Since authorisation records are now stored in tuples (#77), we need to update Resources gRPC endpoints to use tuples instead of records.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 93.33%. Comparing base (a8cc563) to head (7475d91).

Files Patch % Lines
src/svc/resources.cpp 84.21% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   93.95%   93.33%   -0.62%     
==========================================
  Files          20       20              
  Lines        1207     1245      +38     
  Branches      113      123      +10     
==========================================
+ Hits         1134     1162      +28     
- Misses         60       67       +7     
- Partials       13       16       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uatuko uatuko marked this pull request as ready for review April 23, 2024 11:39
@uatuko uatuko mentioned this pull request Apr 23, 2024
14 tasks
@uatuko uatuko merged commit 5d41255 into main Apr 23, 2024
@uatuko uatuko deleted the feature/resources-tuples branch April 23, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant