Conversation
Drop testing from build jobs since testing is done in ci workflow now.
661f402 to
65aa754
Compare
Although googletest recommends using the latest commit from the main branch as often as possible, we also need to know which exact version we are using for debugging purposes. We could use a git commit hash for the version but this isn't very human friendly, so using a tagged version instead.
65aa754 to
3fd58d1
Compare
uatuko
commented
Oct 31, 2024
`BUILD_TESTING` is a well known cmake option but this also means it could get set unintentionally by other projects (e.g. libuv).
4b14b60 to
9413773
Compare
b679bcf to
7f86c0f
Compare
tchernobog
reviewed
Nov 1, 2024
8c33cd3 to
dde6679
Compare
8035a0e to
84cf00e
Compare
84cf00e to
6ef6fa8
Compare
tchernobog
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly to move testing to the CI workflow and leave build jobs to focus on release builds.