Bumped Apache Tike to 3.2.3 with tests#2922
Conversation
Bumped tikaVersion from 1.28.5 to 3.2.3 in gradle.properties Updated JaxbPortalDataHandlerService.java for three Tika 2.x API changes: org.apache.tika.io.CloseShieldInputStream → org.apache.commons.io.input.CloseShieldInputStream Added TikaCoreProperties import and swapped Metadata.RESOURCE_NAME_KEY → TikaCoreProperties.RESOURCE_NAME_KEY Added a new test class covering XML, ZIP, JAR, and gzip detection
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s Apache Tika dependency to a newer major version and updates JaxbPortalDataHandlerService to account for Tika API changes, with a new unit test validating media-type detection for common archive formats.
Changes:
- Bump
tikaVersioningradle.propertiesto3.2.3. - Update Tika integration in
JaxbPortalDataHandlerService(CloseShieldInputStream package + metadata resource name key). - Add
JaxbPortalDataHandlerServiceTestto cover XML/ZIP/JAR/gzip media type detection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
gradle.properties |
Updates Tika version (and also changes project version suffix). |
uPortal-io/uPortal-io-core/src/main/java/org/apereo/portal/io/xml/JaxbPortalDataHandlerService.java |
Adjusts imports and metadata key usage for newer Tika APIs. |
uPortal-io/uPortal-io-core/src/test/java/org/apereo/portal/io/xml/JaxbPortalDataHandlerServiceTest.java |
Adds tests for media type detection across several content types. |
Comments suppressed due to low confidence (1)
gradle.properties:22
- The project
versionis being changed from6.0.0-SNAPSHOTto6.0.0-SNAPSHOT-BS, but the PR title/description only mention the Apache Tika bump. If this suffix change is intentional, it should be called out explicitly in the PR description (or moved to a separate PR), since it can affect artifact coordinates and downstream builds.
version=6.0.0-SNAPSHOT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It is worth noting that Tika 3 requires Java 11 (17 is recommended). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumped tikaVersion from 1.28.5 to 3.2.3 in gradle.properties
Updated JaxbPortalDataHandlerService.java for three Tika 2.x API changes: org.apache.tika.io.CloseShieldInputStream → org.apache.commons.io.input.CloseShieldInputStream
Added TikaCoreProperties import and swapped Metadata.RESOURCE_NAME_KEY → TikaCoreProperties.RESOURCE_NAME_KEY
Added a new test class covering XML, ZIP, JAR, and gzip detection