Minor code refactoring changes#2778
Merged
Merged
Conversation
added 4 commits
March 25, 2024 18:45
ChristianMurphy
approved these changes
Mar 26, 2024
ChristianMurphy
left a comment
Member
There was a problem hiding this comment.
Thanks @HimanshiVerma05!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This PR includes minor code refactoring changes -
Introduce Explaining Variables: To make code more readable I have introduced variables.
Decompose Complex Condition: Decomposed complex if condition to make it more readable
Use Constructor Injection: Instead of using setter injection for usernameAttributeProvider and personAttributeDao, you can use constructor injection. This ensures that the dependencies are injected when the object is created and makes the class immutable.
Extract Method for Query Transformation: The switch statement that modifies the query based on the search method can be extracted into a separate method for better readability and maintainability.
Use Diamond Operator: When creating instances of collections, you can use the diamond operator (<>) to reduce redundant type declarations.