Skip to content

Increasing Test Coverage#2769

Merged
ChristianMurphy merged 4 commits into
uPortal-Project:masterfrom
HimanshiVerma05:master
Mar 21, 2024
Merged

Increasing Test Coverage#2769
ChristianMurphy merged 4 commits into
uPortal-Project:masterfrom
HimanshiVerma05:master

Conversation

@HimanshiVerma05

@HimanshiVerma05 HimanshiVerma05 commented Mar 20, 2024

Copy link
Copy Markdown
Contributor
Checklist
  • the [individual contributor license agreement][] is signed
  • commit message follows [commit guidelines][]
  • tests are included
Description of change

Increased the code test coverage by adding new test cases .

@ChristianMurphy ChristianMurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @HimanshiVerma05!
Thanks for sharing new test cases!

When you have a chance could you apply the Google Java format to the code.
You could do this manually, or automatically with ./gradlew goJF.

@HimanshiVerma05

HimanshiVerma05 commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

Welcome @HimanshiVerma05! Thanks for sharing new test cases!

When you have a chance could you apply the Google Java format to the code. You could do this manually, or automatically with ./gradlew goJF.

Hi @ChristianMurphy . Sure ! Let me do it right away!

@HimanshiVerma05

Copy link
Copy Markdown
Contributor Author

Hi @ChristianMurphy . Done !

@ChristianMurphy ChristianMurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HimanshiVerma05! 🙇

@ChristianMurphy ChristianMurphy merged commit 8ae62f2 into uPortal-Project:master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants