Thanks @KiruthikaJanakiraman!
To clarify, I believe the intent of this test is to be order insensitive.
Would this change it to become order sensitive and potentially cause tests to fail over a property (order) we don't intend to check?

Hi,
The assert statement checks for a specific order of parameters. Doesn't that make the test order sensitive?
Since the order of iteration is not guaranteed in a HashMap, the order of the parameters tends to get shuffled, causing the test to fail as the test is checking for a specific url string.
By using a LinkedHashMap, I am trying to preserve the order of the parameters.

If the test is meant to be order insensitive, an alternative fix could be to assert for both possible orders, i.e.,
"http://somewhere.com/something?action=show&list=v1&list=v2&username=student"
OR
"http://somewhere.com/something?list=v1&list=v2&action=show&username=student"

If you prefer the latter fix, kindly let me know and I could update the PR.

The assert statement checks for a specific order of parameters. Doesn't that make the test order sensitive?

You are right, the test in is current form is indeed order sensitive.
This is testing URL query params. Query params are not order sensitive.
I'd personally lean that the test could/should account query params being in any/different order.
But I'd be interested to hear what you (@KiruthikaJanakiraman) and others (@uPortal-Project/uportal-committers) think.

I think the test should be changed to account for any order.

This is testing URL query params. Query params are not order sensitive.

That makes sense. If the test is meant to be order insensitive, I would suggest 2 alternative fixes:

1. Checking for both possible order of additionalParameters
2. Writing a custom function to compare urls with different query parameter orders

Could you kindly let me know the preferred fix?

I have updated the commit with a custom function that compares two urls two urls irrespective of the order of the query parameters. Could you kindly review the same?

@KiruthikaJanakiraman could you run ./gradlew goJF to format the changes?
CI is getting stuck on the format checking step https://github.com/uPortal-Project/uPortal/actions/runs/6828454623/job/18572610313?pr=2719#step:5:51