Skip to content

unit test implemented#2715

Merged
bjagg merged 2 commits into
uPortal-Project:masterfrom
snehit221:dev-snehit-unit-test-impl
Nov 10, 2023
Merged

unit test implemented#2715
bjagg merged 2 commits into
uPortal-Project:masterfrom
snehit221:dev-snehit-unit-test-impl

Conversation

@snehit221

@snehit221 snehit221 commented Nov 2, 2023

Copy link
Copy Markdown
Contributor
Checklist
  • the individual contributor license agreement is signed
  • commit message follows commit guidelines
  • tests are included
  • documentation is changed or added
  • new security keys and comments added to security.properties
  • new general keys and comments added to portal.properties
  • any changes that impact configuration or the database DDL added to CHANGES.md
  • message properties have been updated with new phrases
  • view conforms with WCAG 2.0 AA
Description of change

Aim is to increase the test coverage, line coverage and branch coverage of the modules I have implemented the unit tests for.

@ChristianMurphy

Copy link
Copy Markdown
Member

Welcome @snehit221! 👋
Thanks for taking the time to contribute!

  1. When you have a chance, could you submit the Apereo ICLA? https://www.apereo.org/licensing/agreements/icla
  2. The tests are currently failing due to formatting, could you run ./gradlew goJF and commit the updated files?
  3. To confirm your goal, you are aiming to increase test coverage? (Very much appreciated) Or is there also a bug you are trying to reproduce?

@ChristianMurphy

Copy link
Copy Markdown
Member

@snehit221 friendly reminder, this still has some open questions 🔔

@snehit221

Copy link
Copy Markdown
Contributor Author

@ChristianMurphy ,
Thanks for your revert. I have fixed the formatting issues as advised and filled the form as well.
My primary goal was to increase the test coverage. I will explore more and will now try to find implementation / design smells and refactor them.

@bjagg bjagg merged commit 195c719 into uPortal-Project:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants