Skip to content

UPSE-387: Update portlets.json REST endpoint to allow filtering by user's portlet permission and favorite/unfavorite#2689

Merged
bjagg merged 1 commit into
uPortal-Project:masterfrom
groybal:UPSE-387
Aug 4, 2023
Merged

UPSE-387: Update portlets.json REST endpoint to allow filtering by user's portlet permission and favorite/unfavorite#2689
bjagg merged 1 commit into
uPortal-Project:masterfrom
groybal:UPSE-387

Conversation

@groybal

@groybal groybal commented Aug 4, 2023

Copy link
Copy Markdown
Contributor
Checklist
Description of change

This PR updates the api/portlets.json REST endpoint to optionally allow two new parameters:

  • "requiredPermissionType": restricts the results to portlets for which the user has the specified permission; if not provided, then defaults to MANAGE
  • "favorite": when true, limits results to those that have been favorited by the user; when false, limits the results to those that have not been favorited

bjagg
bjagg requested changes Aug 4, 2023
View reviewed changes
Comment thread uPortal-api/uPortal-api-rest/src/main/java/org/apereo/portal/rest/PortletsRESTController.java Outdated
bjagg
bjagg approved these changes Aug 4, 2023
View reviewed changes

@bjagg bjagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🏆

Comment thread uPortal-api/uPortal-api-rest/src/main/java/org/apereo/portal/rest/PortletsRESTController.java
@bjagg

bjagg commented Aug 4, 2023

Copy link
Copy Markdown
Member

Minor pt: rename this PR please

@groybal
UPSE-387: Update portlets.json REST endpoint to allow filtering by us…
4fdda56 
…er's portlet permission and favorite/unfavorite
@groybal groybal changed the title work-in-progress UPSE-387: Update portlets.json REST endpoint to allow filtering by user's portlet permission and favorite/unfavorite Aug 4, 2023
@groybal

groybal commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

Minor pt: rename this PR please

done

@groybal groybal closed this Aug 4, 2023
@groybal groybal reopened this Aug 4, 2023
@groybal groybal marked this pull request as ready for review August 4, 2023 20:59
@bjagg bjagg merged commit 7bbe7db into uPortal-Project:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjagg bjagg bjagg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@groybal @bjagg