Skip to content

UPSE-385: Fix portlet config cancel (was doing save)#458

Merged
loulou2u merged 1 commit into
uPortal-Project:masterfrom
groybal:UPSE-385
Jul 21, 2023
Merged

UPSE-385: Fix portlet config cancel (was doing save)#458
loulou2u merged 1 commit into
uPortal-Project:masterfrom
groybal:UPSE-385

Conversation

@groybal

@groybal groybal commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

This PR fixes the "Return without saving" link on the Content Editor (config) page. Previously, that link was actually causing the changes to get saved.

Tested through both portlet 'Configure' and through Portlet Admin flows.

@sonatype-lift

sonatype-lift Bot commented Jul 17, 2023

Copy link
Copy Markdown

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I just remembered that I didn't test the changes in this file (though the changes are the same as those in src/main/webapp/WEB-INF/jsp/configureContent.jsp) because I wasn't sure how to. Where does this 'webcomponent' jsp get used???

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create a portlet, there should be an option to create a "Web Component" portlet which was added to assist with getting web components into uPortal using the web UI (#118). It does not have the editor like the simple and advanced CMS portlet does

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was able to test the webcomponent editor and the changes work.

@cbeach47 cbeach47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks @groybal !

Comment thread src/main/webapp/WEB-INF/jsp/configureContent.jsp
Comment thread src/main/webapp/WEB-INF/jsp/webcomponent/configureContent.jsp Outdated
Comment thread src/main/webapp/WEB-INF/jsp/webcomponent/configureContent.jsp Outdated
@loulou2u loulou2u self-requested a review July 21, 2023 20:36

@loulou2u loulou2u left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Tested successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants