Prerequisites
Description
I believe the "Malvertising filter list by Disconnect" is not in the right category.
It is a combination of three other lists : an ad list, a tracking list, and a malware list.
Therefore, I think it belongs in the "Multipurpose" category.
But here are some notes:
- The malware part of this list is actually only one domain long and it is Disconnect's own test domain. It offers no malware protection whatsoever, so its current category (and title, but that's irrelevant) is misleading.
- The dedicated malware list is as empty as this one.
- One domain from the dedicated ad list is not included in this list. It seems the script Disconnect uses to combine the three lists into one replaces the first line from the ad list with the only line from the malware list.
With this in mind, I would suggest two solutions:
- Move the list to the "Multipurpose" category.
OR
- Replace this list with its components: the ad and tracking lists (not the malware one, because it is empty, as we've seen above).
As a reminder, here are the 4 URLs to the lists:
Ad list: https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt
Tracking list: https://s3.amazonaws.com/lists.disconnect.me/simple_tracking.txt
Malware list: https://s3.amazonaws.com/lists.disconnect.me/simple_malware.txt
Combination of the three lists above, the one currently included in uBlock Origin: https://s3.amazonaws.com/lists.disconnect.me/simple_malvertising.txt
A specific URL where the issue occurs
N/A
Steps to Reproduce
- Open uBlock Origin's dashboard
- Navigate to "Filter lists"
- Observe the misplacement of "Malvertising filter list by Disconnect" in the "Malware domains" category
Expected behavior:
- The malvertising list is in the "Multipurpose" category.
OR
- Its components are in the appropriate categories, and used in place of the malvertising list.
Actual behavior:
The malvertising list is in the "Malware domains" category. This is misleading as the list offers no malware protection.
Your environment
- uBlock Origin version: 1.25.2
- Browser Name and version: Firefox 74.0
- Operating System and version: Windows 10
Prerequisites
Description
I believe the "Malvertising filter list by Disconnect" is not in the right category.
It is a combination of three other lists : an ad list, a tracking list, and a malware list.
Therefore, I think it belongs in the "Multipurpose" category.
But here are some notes:
With this in mind, I would suggest two solutions:
OR
As a reminder, here are the 4 URLs to the lists:
Ad list: https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt
Tracking list: https://s3.amazonaws.com/lists.disconnect.me/simple_tracking.txt
Malware list: https://s3.amazonaws.com/lists.disconnect.me/simple_malware.txt
Combination of the three lists above, the one currently included in uBlock Origin: https://s3.amazonaws.com/lists.disconnect.me/simple_malvertising.txt
A specific URL where the issue occurs
N/A
Steps to Reproduce
Expected behavior:
OR
Actual behavior:
The malvertising list is in the "Malware domains" category. This is misleading as the list offers no malware protection.
Your environment