Skip to content

Subscriber script needs to be improved #763

@ghost

Description

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Subscriber scriptlet does not work after navigation in dynamic pages when first loaded page does not have subscribe links. For example on some GitHub pages (dynamic tabs) or Discourse forums (dynamic subforums/categories/comments).

A specific URL where the issue occurs

https://github.com/MajkiIT/polish-ads-filter

Steps to Reproduce

  1. open https://github.com/MajkiIT/polish-ads-filter/issues
  2. click on "<> Code" tab (address will change to https://github.com/MajkiIT/polish-ads-filter)
  3. scroll down to table and click on one of the "Subskrybuj" links

OR

  1. open https://discourse.mozilla.org/t/support-ublock-origin/6746 (first message)
  2. scroll down to my last message (768)
  3. click on subscription link

Expected behavior:

uBO Subscribe dialog should appear

Actual behavior:

Navigation to non existing page.

Your environment

  • uBlock Origin version: 1.22.5rc6, 1.23.0
  • Browser Name and version: Firefox 72, Chrome 77
  • Operating System and version: Manjaro

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions