Skip to content

filter editor search enhancements #493

@filbo

Description

@filbo

Hi,

(mistakenly posted this as uBlockOrigin/uAssets#5241, sorry...)

Within uBO options, when looking at / editing a specific filter list, I was looking for filter lines which would affect github.io. I searched for github and was dismayed to see '1000+' hits in the main 'uBlock filters' list.

Now, there is a trivial workaround for my use case (actually enter github.io); but suppose I were truly looking for an issue with github.com? The 1000+ mentions of https://github.com/uBlockOrigin/uAssets/issues/%d would block me completely.

... which led me to wish for two (and a half) things:

  1. search-within-list which is comment-sensitive; that is, ignore lines which are comments
    a. suboption which includes comments which are valid rule syntax, ignoring only human-readable comments; obviously, not the default...

  2. search-within-list which is domain-sensitive; that is, find rules which match the given domain or domain-wildcard. This would do wildcard matching in both directions: I enter github.io, it matches rules looking for github.io and github.*; I enter github.*, it matches both of those + github.com. Possibly 'domain' is the wrong concept; searching for *.github.io/*.css ought to be able to match rules with that specificity.

The UI could look something like:
uBO-filter-search

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions