Changed the color of found text from red to green#2
Merged
Conversation
Collaborator
|
Green seems to blend in a little, is it possible to make it bold or change text background? |
Owner
Author
|
@Gpax971 Thanks for the comment. I kept the green color and increased the font size and weight for readability. Latest version: |
Collaborator
|
Looks good now. May want to remove the original picture for privacy though |
|
Would it be possible to submit this PR to https://github.com/JabRef/jabref/pulls? |
Owner
Author
|
I just submitted the PR. JabRef#9315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JabRef#552.
This issue is about changing the text color from red to green to avoid misunderstanding in the search.
Before:
The text color of the search was red, which may make users think there was an error in the search.
After:
Highlighted the search text in green color to avoid misunderstanding.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)I would like to know what you think about the fix. Any comments would be appreciated.