feat: adopt compact layout for markup with single primary expressions#400
Merged
QuadnucYard merged 1 commit intotypstyle-rs:masterfrom Aug 2, 2025
Merged
Conversation
📊 Benchmark Performance Reportgroup base pr
----- ---- --
pretty-ai-comprehensive-showcase 1.02 902.5±16.42µs ? ?/sec 1.00 884.1±10.44µs ? ?/sec
pretty-cetz-manual 1.00 747.9±12.03µs ? ?/sec 1.01 755.9±22.48µs ? ?/sec
pretty-codly 1.01 1772.8±22.00µs ? ?/sec 1.00 1763.2±21.83µs ? ?/sec
pretty-cpe 1.51 18.4±2.38ms ? ?/sec 1.00 12.2±0.75ms ? ?/sec
pretty-deep-nested-args 1.00 17.7±0.25µs ? ?/sec 1.01 17.9±0.23µs ? ?/sec
pretty-fletcher-diagram 1.01 517.4±11.38µs ? ?/sec 1.00 513.7±9.58µs ? ?/sec
pretty-fletcher-draw 1.00 1254.5±30.86µs ? ?/sec 1.00 1254.6±10.51µs ? ?/sec
pretty-tablex 1.01 3.4±0.02ms ? ?/sec 1.00 3.3±0.02ms ? ?/sec
pretty-touying-core 1.00 2.1±0.02ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
pretty-touying-utils 1.01 1201.4±26.23µs ? ?/sec 1.00 1190.8±17.98µs ? ?/sec
pretty-undergraduate-math 1.00 856.8±14.30µs ? ?/sec 1.02 870.5±90.21µs ? ?/sec📏 Binary Size Comparison
📦 Detailed Crate Size Diff (cargo-bloat)Note: Numbers above are a result of guesswork. They are not 100% correct and never will be. @@ -1,8 +1,8 @@
-std 392.0 kB
+std 391.9 kB
clap_builder 342.3 kB
-typstyle_core 200.8 kB
+typstyle_core 201.7 kB
typst_syntax 141.4 kB
clap_complete 130.8 kB
similar 72.5 kB
typstyle 54.7 kB
walkdir 19.4 kBGenerated by GitHub Actions on 2025-08-01 15:54:13 UTC |
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Does this imply we should choose one of them? |
Collaborator
Author
sorry I didn't make it clear. The two both touch the markup boundary, and that's a git conflict. |
7cd8f67 to
0f1f9ad
Compare
0f1f9ad to
6ddebbc
Compare
Enter-tainer
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21, #82