feat: format args and hashed expressions in math#247
Merged
QuadnucYard merged 2 commits intotypstyle-rs:masterfrom Mar 28, 2025
Merged
feat: format args and hashed expressions in math#247QuadnucYard merged 2 commits intotypstyle-rs:masterfrom
QuadnucYard merged 2 commits intotypstyle-rs:masterfrom
Conversation
📊 Benchmark Performance Reportgroup base pr
----- ---- --
attrs-cetz-manual 1.40 87.7±8.75µs ? ?/sec 1.00 62.8±0.65µs ? ?/sec
attrs-codly 1.24 240.5±20.85µs ? ?/sec 1.00 193.5±2.61µs ? ?/sec
attrs-fletcher-diagram 1.28 51.0±0.39µs ? ?/sec 1.00 40.0±6.76µs ? ?/sec
attrs-fletcher-draw 1.29 153.5±9.98µs ? ?/sec 1.00 118.8±2.16µs ? ?/sec
attrs-tablex 1.19 459.9±2.84µs ? ?/sec 1.00 386.4±3.15µs ? ?/sec
attrs-touying-core 1.23 293.7±10.21µs ? ?/sec 1.00 239.7±2.63µs ? ?/sec
attrs-touying-utils 1.25 159.0±1.68µs ? ?/sec 1.00 127.3±2.97µs ? ?/sec
attrs-undergraduate-math 1.31 119.7±6.89µs ? ?/sec 1.00 91.1±1.31µs ? ?/sec
pretty-cetz-manual 1.03 754.5±6.13µs ? ?/sec 1.00 731.9±19.36µs ? ?/sec
pretty-codly 1.02 1783.9±11.88µs ? ?/sec 1.00 1756.2±10.70µs ? ?/sec
pretty-fletcher-diagram 1.03 511.5±7.15µs ? ?/sec 1.00 497.6±6.80µs ? ?/sec
pretty-fletcher-draw 1.02 1228.5±10.61µs ? ?/sec 1.00 1205.6±12.20µs ? ?/sec
pretty-tablex 1.02 3.4±0.04ms ? ?/sec 1.00 3.3±0.01ms ? ?/sec
pretty-touying-core 1.03 2.2±0.01ms ? ?/sec 1.00 2.1±0.01ms ? ?/sec
pretty-touying-utils 1.02 1194.9±11.22µs ? ?/sec 1.00 1172.7±29.33µs ? ?/sec
pretty-undergraduate-math 1.01 835.2±7.71µs ? ?/sec 1.00 826.2±6.46µs ? ?/secGenerated by GitHub Actions on Fri Mar 28 02:56:10 UTC 2025 |
Collaborator
|
interestingly this pr greatly improves the performance🤔 |
Collaborator
Author
No, just because the computation of attributes is simplified due to fewer disabling cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22. Fixes #132 and #141.
There are some problems:
sinandcases. They have the same AST, but only the latter is really a function. Therefore, we must keep commas in args and not add extra ones.These problems mean we have to keep the structure.
Line-breaking in math is also suppressed.