add support for testing on prereleases#31
Closed
ensko wants to merge 1 commit intotypst-community:mainfrom
Closed
Conversation
a9ab4b9 to
8746403
Compare
8746403 to
008d984
Compare
Collaborator
Author
|
(since 0.13 and Tytanic 0.2 are out, this becomes a lot less urgent and should probably wait for taiki-e/install-action#858) |
5694cbb to
46347c5
Compare
46347c5 to
f6e560c
Compare
Collaborator
Author
|
Thanks to taiki-e/install-action#868, this is now supported without change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this should be merged, would be interested in others' opinions.
I think it's in general useful to have support for testing on prereleases (conditioned on both a Typst and compatible Tytanic prerelease already existing of course). However, the binstall action we use doesn't support prereleases:
So this requires extra measures to use
cargo installinstead. Also, since a prerelease is not the real thing yet, should the template explicitly use them? And if not, is the infrastructure for prereleases still "appropriate" to include?Basically the options I see are
I lean towards this being useful enough for package authors to merge in one of the two ways, but would like others' take on this.