Merged
Conversation
|
Would you be open to a PR that would check the generated output in CI here? Maybe only when either the file changes or there is a version bump? |
Member
Author
|
I still want to pin the specs to specific version (e.g. https://html.spec.whatwg.org/commit-snapshots/942e63def84b91fa62efd1f924e3f330ad15c62f/; I still need to research perma-links for the other specs) to make it reproducible. Once that's done and this here is merged, I would definitely be open for a CI PR. As of yet, typst-assets has no CI at all, so that would be a first step. We can then discuss whether we want to do the code generation CI on every commit or not (it wouldn't be too bad here as typst-assets gets far fewer commits than typst proper). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to typst/typst#6476.