Return friendly error when loading JSON has a leading UTF‑8 BOM#7488
Merged
laurmaedje merged 3 commits intotypst:mainfrom Dec 1, 2025
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5440
close #3157
This pull request improves the handling of JSON files in the loading library by adding explicit detection and error reporting for files that start with a UTF-8 Byte Order Mark (BOM), which is not allowed by the JSON specification.
Although the JSON specification does not allow BOM, we could consider a more forgiving approach that removes the BOM when encountering BOM-prefixed JSON files. However, in my opinion, most major programming languages throw an error for JSON files with a BOM. To maintain consistent and clear behavior, this PR opts to throw a friendly error message in such cases.