Merged
Conversation
016b5f3 to
f86453f
Compare
f86453f to
bf8ef2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
preelements that start with a newline<script>and<style>) by not writing escape sequences. When a closing tag is detected in the text, the export errors as there is no way to encode it. When pretty-printing is enabled, the contents of the raw text element are only indented if we are sure it's JS/CSS (notypeattr telling us something else) and, in the case of JS, if there are no backticks in it because the semantics of multiline template string literal could be changed by indent.Infrastructure-wise, this PR adds support for HTML export errors in the test runner and also cleans up a few error messages. The PR is best looked at commit-by-commit and will be merged without squash.