fix(ci): include rust-src in flake.nix#6107
fix(ci): include rust-src in flake.nix#6107michaelfortunato wants to merge 1 commit intotypst:mainfrom
Conversation
PgBiel
left a comment
There was a problem hiding this comment.
I'll note that the dev shell is mostly just there to make it easier to get the recommended tooling versions going on your machine, but in principle this should be handled in your own dev environment. Though I am not strictly opposed to adding this if others see value in it. cc @drupol
| rust-toolchain = fenix.packages.${system}.combine [ | ||
| (fenix.packages.${system}.fromManifestFile | ||
| rust-manifest).defaultToolchain | ||
| (fenix.packages.${system}.fromManifestFile rust-manifest).rust-src | ||
| ]; |
There was a problem hiding this comment.
This should not be added here, as it is not needed to build Typst. Only the development shell could depend on rust-src if it is decided that way.
There was a problem hiding this comment.
Oof yes my bad. And yeah, worth emphasizing again that adding rust-src in the devshell increases startup time noticeably.
There was a problem hiding this comment.
This is the price to pay to have a reproducible dev environment.
Maybe not worth it then? |
|
I can't reproduce this issue any longer on main . Closing it. Sorry for the noise. Thanks for engaging with me. |
rust-src was not available in the flake.nix, breaking rust-analyzer when using nix develop.
I tried to capture the before and after here, but the red squiggly lines did not show up, you will notice that I cannot do lsp actions before and then can after.
https://asciinema.org/a/XzG8hoWcLV5NLPSkIgKGSo80i
Fixes #6105