More flexible and efficient Bytes representation#5670
Merged
laurmaedje merged 1 commit intomainfrom Jan 8, 2025
Merged
Conversation
Any `AsRef<[u8]>` or `AsRef<str>` can now back the `Bytes`, so we can use types like the following without copying into a new vector: `[u8; 8]`, `EcoString`, `String`. Of course, `&'static [u8]` is also possible, but this was the case before as well. This removes the `From<&[u8]>` and `From<Vec<u8>>` impls from `Bytes` because they may hide unnecessary copies and `Bytes::new` forces the caller to think more about what they want to pass in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any
AsRef<[u8]>orAsRef<str>can now back theBytes, so we can use types like the following without copying into a new vector:[u8; 8],EcoString,String. Of course,&'static [u8]is also possible, but this was the case before as well.This also removes the
From<&[u8]>andFrom<Vec<u8>>impls fromBytesbecause they may hide unnecessary copies andBytes::newforces the caller to think more about what they want to pass in.